• New skills/work-graph-node-review/SKILL.md documents the methodology for
    judging a self-planned Work Graph node's output (real structured content
    vs. narrative prose standing in for it) -- distilled from the real
    narrative-output incident (docs/todo/validator-test-script-narrative-
    output-issue.md §6) and the conditional-not-assertive phrasing lesson
    already applied in _NARRATION_RETRY_HINT. Scoped explicitly against
    planner-output-review (Planner's fixed doc chain, task-level gate),
    qa-task-validation (overall task acceptance), and skill-defect-remediation
    (rewriting a Skill file itself) -- this one judges a single self-planned
    node's output, nothing broader.
    
    Wired into roles/planner_reviewer, roles/coder, roles/validator role.json
    skills lists. .claude/agents/*.md left untouched -- that's a deploy-time
    artifact compiled from role.json by agent_profile.deploy_agent_definitions(),
    not hand-synced (confirmed stale already: coder.md is missing an even
    earlier Phase 2a skill addition).
    
    This completes Phase 2c (§2.1/§2.2/§6/§7.1 all implemented; §7.2's
    analysis was completed earlier without needing a code change).
    
    Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
    bboonnee authored
     
    Browse File »

  • Inserts Planner -> planner_reviewer -> Coder -> Validator into the fixed Org
    Graph flow (was Planner -> Coder -> Validator), per
    docs/todo/org-graph-unification-phase1-review-gate-design.md. A new
    planner_reviewer role independently judges whether Planner's BRD/PRD/SDD/
    Benchmark output is real structured content (not narrative prose) before
    Coder is allowed to start, with a 3-attempt retry loop and a narration
    heuristic informed by the real narrative-output incident
    (docs/todo/validator-test-script-narrative-output-issue.md).
    
    Also fixes, in the same code path:
    - The P0 bug in task-execution-resume-assumes-planner-artifacts-exist.md:
      resuming a task no longer assumes sdd/prd/benchmark artifacts exist --
      falls through to real replanning when they don't.
    - A fresh-run KeyError (not resume-specific) when a self-planned graph omits
      the prd/benchmark node types.
    - agent_profile.migrated_from_profile was NOT NULL, which broke as soon as a
      role with no legacy Hermes profile (planner_reviewer) was recorded.
    
    org_node_lifecycle._REQUIRED_ARTIFACTS["coder"] is narrowed from
    (brd,prd,sdd,benchmark) to (sdd,) -- the old 4-artifact gate never actually
    blocked anything since artifact_write.py sets validation_status='passed'
    unconditionally; planner_reviewer is the first real semantic gate.
    
    Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
    bboonnee authored
     
    Browse File »