宜博 / lemongraph

update_skill(): writes new Skill content to skills/<skill_id>/SKILL.md and
commits it (03-C §3.8: file write + git commit must be atomic -- the DB
insert only happens after the commit succeeds, so a git failure naturally
leaves no orphaned skill_iteration row, no separate rollback machinery
needed), rejects a missing triggered_by_bug_id (MISSING_TRIGGER_REF).
rollback_skill(): restores the pre-iteration content from
before_git_commit_sha and commits *that* as a new commit + new
skill_iteration row (03-C §3.9: rollback is itself a new iteration, not a
history rewrite); the rollback record's triggered_by_bug_id reuses the
original iteration's, since c_skill_rollback's input contract has no bug_id
of its own and that FK is NOT NULL.

repo_path has no default (caught and fixed during this Unit, not shipped
with the bug): an earlier draft defaulted it to this repo's own root,
which would have made any test that forgot to override it silently commit
into graphlemon's actual git history. Every call site must now be
explicit; git log confirms nothing leaked into this repo while building
and testing it.

Resolves U-015's deferred skill_defect gap: re-reading 04-P §4.3's own
transition table, bug_recorded (c_bug_record_create alone) and
skill_iteration_triggered (-> c_skill_update) are separate, sequential
transitions, not one atomic call -- so 03-C §3.10's "必须同时创建
skill_iteration_suggestion" is a same-flow requirement, not a same-API-call
one. bug_record.py already accepted skill_defect (it was never actually
rejected, just undocumented as resolved); update_skill() now fills in
bug_record.skill_iteration_suggestion_id once the real iteration exists.

Known gap, not this Unit's job: no real Skill content has been migrated
from the Hermes profiles yet (05 §5.1 names the skills; agent_profile.py's
frontmatter only references them by name) -- tests seed a placeholder
skill file, same pattern as U-010/011 seeding placeholder artifacts for
upstream producers that don't exist yet.

10 new stdlib unittest cases, all real (git + sqlite, no LLM call needed --
same category as U-013's worktree tests). 167 total across U-001-018, all
passing.

This closes PH2-S2. REQ-08 is now real code, and U-015's skill_defect note
is resolved rather than left permanently deferred.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

judge_root_cause(): runs 3 perspective_fns (correctness/requirement-
completeness/skill-defect, 04-P §4.3), requires >=2/3 agreement on a
category or raises InconclusiveEscalateError with all raw judgments
attached (REQ-04's failure case). trace_root_cause_test_failed() creates a
brand-new bug_record on agreement; trace_root_cause_human_reported()
field-completes an existing one instead (04-P's explicit distinction
between the two origins, not a new record either way).

c_bug_record_create (bug_record.py): validates root_cause_category against
{planning, coder, skill_defect} -- core_engine deliberately excluded,
matching U-001's schema CHECK constraint (PH5/U-034 scope). Known,
deliberately-unenforced gap noted rather than guessed at: 03-C §3.10's
"skill_defect requires creating a skill_iteration_suggestion" constraint
can't be satisfied yet (skill_iteration.before/after_git_commit_sha are
NOT NULL but don't exist until a real skill rewrite happens in U-018) --
REQ-04's three cases never exercise skill_defect, so nothing here needs it
resolved yet.

real_validator_perspective() builds a real claude --agent validator call
framed from one of the three perspectives, parsing a CATEGORY:/DETAIL:
response format.

Also fixes a real diagnostic bug found investigating an unrelated failure:
org_node_trigger.py/work_graph_plan.py/work_graph_execute.py's nonzero-exit
error paths only included stderr in the raised exception, silently
dropping stdout -- which is where a real `claude` failure's actual detail
often lives. A real Coder call failed with exit 1 and empty stderr,
giving zero diagnostic signal; fixed to include both streams (truncated).

18 new mocked stdlib unittest cases + 1 gated real test (3 real Validator
perspective calls judging a deliberately-injected wall-collision bug,
expecting agreement on root_cause_category=coder). 146 total mocked tests
across U-001-015, all passing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>