• Phase 1 (planner_reviewer review gate + P0 resume-bug fix) shipped as
    ea19c7d, matching org-graph-unification-phase1-review-gate-design.md
    exactly (new task.status value, org role, _REQUIRED_ARTIFACTS narrowing,
    both bugs fixed). Moving that design doc and the P0 bug doc it subsumed
    to docs/done/, updating their status headers, and fixing the doc-path
    references left pointing at their old docs/todo/ location across
    agents/planner_reviewer/{SOUL,AGENTS}.md, src/schema.py migration
    docstrings, and the other Phase 2/deblackbox docs. Full suite green
    (731 tests) both before and after.
    
    Also ran Phase 2 SDD's §9 interface-reconciliation checklist against the
    real Phase 1 implementation now that it exists for real: all three items
    check out (run_id is included in plan_and_review_documents()'s return
    shape, the new task.status value is exactly reviewing_planner_output as
    assumed, and planner_reviewer's role.json doesn't pre-reserve a skill
    slot for Phase 2's new skill, which is fine -- a one-line addition when
    Phase 2c lands, not an incompatibility). Updated §9 to reflect this.
    
    Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
    bboonnee authored
     
    Browse File »

  • User's key insight, recorded as a goal in the requirements doc (new §3.1):
    a failed node shouldn't just get a corrective retry (fix-bug, forgotten
    after this run) -- when the root cause is a systemic Skill defect, the
    Skill itself must be fixed (fix-skill, persists across all future tasks).
    Four-step chain: judgment fails -> Reflection-review node does full-chain
    root-cause diagnosis (one-off content error vs systemic skill defect) ->
    if systemic, a Fix-skill node calls the already-existing skill iteration
    machinery (skill_update.py::update_skill() + bug_record.py, real Git-
    versioned commits, previously only reachable via org_level_loop.py's
    coarse Org-level path, never from inside a Work Graph's own judgment/
    loop_back cycle) -> loop back and re-run using the updated skill.
    
    Cross-referenced into the Phase 2 design doc: its dynamic_loop_back (§5)
    implements steps 1/2/4 of this chain but not step 3 (Fix-skill) -- flagged
    as the largest known scope gap in §8, not a missed detail.
    
    Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
    bboonnee authored
     
    Browse File »
  • Design for FR-2/FR-3/FR-4: extending self-planning to Coder/Validator,
    per-node subagent/skill/tools binding, and node-level precise loop_back
    replacing org_level_loop.py's coarse fast_lane/full_replan routing.
    
    Three findings during design research that revise the requirements doc's
    original FR-2 assumption ("just swap the call site"):
    - _GENERIC_PROMPT_TEMPLATE never solicits judgment/on_fail today -- Coder/
      Validator switching to plan_work_graph() as-is would produce graphs with
      no judgment/loop-back capability at all.
    - run_graph()'s subagent_type/skill_ref are run-level constants passed to
      every node identically, not node-level despite work_node_execution
      already having columns for it -- needs a real (bounded) engine extension.
    - Today's on_fail.action="loop_back" target is statically declared at
      planning time via a single on_failure edge; it cannot express "a
      terminal validator dynamically diagnoses which of several ancestor
      nodes is the true root cause." New on_fail.action="dynamic_loop_back"
      designed for this, reusing root_cause_trace.py's jury/majority-vote
      structure with the vote target changed from a category to a node_id.
    
    Also incorporates three requirements-doc §7 decisions that were made
    (apparently concurrently) while this was being designed and overrule two
    of this doc's initial drafts: work_graph_run.org_node is removed entirely
    (not kept/sunk to node level) with concrete work_graph_run_query.py/
    work_graph_fork.py rework; Coder/Validator get a suggested node-type
    catalog (not fully free-form); the append interface is a parameter on
    the existing plan_work_graph() (not a new function).
    
    Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
    bboonnee authored
     
    Browse File »