Commit e9aeecdc5498523e9b61d079f396b61f47d52db6
1 parent
5abfea66
graphlemon: auto-commit uncommitted changes for 55f7adaa-40f2-40cd-bde4-3ee67d46840c
Showing
3 changed files
with
30 additions
and
0 deletions
.claude/agent-memory/coder/MEMORY.md
| 1 | - [Loop-limit comment task keeps re-dispatching with zero diff](task_dispatch_loop_limit_comment_repeat.md) — src/org_loop_route.py:38 comment already exists; verify and report, don't re-add | 1 | - [Loop-limit comment task keeps re-dispatching with zero diff](task_dispatch_loop_limit_comment_repeat.md) — src/org_loop_route.py:38 comment already exists; verify and report, don't re-add |
| 2 | - [deploy_health_check timeout comment fixed 2026-08-03](project_deploy_health_check_startup_timeout_comment_resolved.md) — PH5 already shipped, old "defer" reasoning is stale; check dev-plan closure before citing phase gates | 2 | - [deploy_health_check timeout comment fixed 2026-08-03](project_deploy_health_check_startup_timeout_comment_resolved.md) — PH5 already shipped, old "defer" reasoning is stale; check dev-plan closure before citing phase gates |
| 3 | +- [deploy_health_check HTTP timeout comment fixed 2026-08-03](project_deploy_health_check_http_timeout_comment_resolved.md) — separate constant from STARTUP_TIMEOUT case, third planner cycle before a Coder applied it |
.claude/agent-memory/coder/project_deploy_health_check_http_timeout_comment_resolved.md
0 → 100644
| 1 | +--- | ||
| 2 | +name: project-deploy-health-check-http-timeout-comment-resolved | ||
| 3 | +description: HEALTH_CHECK_HTTP_TIMEOUT comment gap fixed 2026-08-03 — distinct from the already-resolved STARTUP_TIMEOUT case | ||
| 4 | +metadata: | ||
| 5 | + type: project | ||
| 6 | +--- | ||
| 7 | + | ||
| 8 | +`supervisor/deploy_health_check.py`'s `HEALTH_CHECK_HTTP_TIMEOUT = 10` had no comment directly | ||
| 9 | +above it (only `HEALTH_CHECK_STARTUP_TIMEOUT`, one constant above it, had one — Python comments | ||
| 10 | +attach only to the immediately following line, so the two constants needed separate comments). | ||
| 11 | +Three consecutive Planner-role runs (PRD, PRD, then a full SDD defining `DOC-FIX-U038-01`) had | ||
| 12 | +independently reached this same conclusion without a Coder-role node ever applying the diff. | ||
| 13 | + | ||
| 14 | +**Fixed 2026-08-03**: added `# MVP engineering estimate per 05 §5.9 -- needs real-world | ||
| 15 | +calibration, not an authoritative constant.` directly above `HEALTH_CHECK_HTTP_TIMEOUT = 10`. | ||
| 16 | +No other lines changed. Verified via `git diff` and by re-running | ||
| 17 | +`python3 -m unittest supervisor.test_deploy_health_check -v` (13 tests, all pass — comment-only | ||
| 18 | +change needs no new test). | ||
| 19 | + | ||
| 20 | +`HEALTH_CHECK_CANARY_TIMEOUT` still lacks its own comment and remains out of scope (a separate | ||
| 21 | +potential future task, not part of this fix). See [[project_deploy_health_check_startup_timeout_comment_resolved]] | ||
| 22 | +for the earlier STARTUP_TIMEOUT fix this complements. | ||
| 23 | + | ||
| 24 | +**Why:** this is the third time planning re-derived the same fix without execution — the gap was | ||
| 25 | +in handoff to a Coder-role node, not in the plan quality. | ||
| 26 | + | ||
| 27 | +**How to apply:** N/A, already resolved. If asked to check again, verify on disk first — don't | ||
| 28 | +assume stale from memory alone. |
supervisor/deploy_health_check.py
| @@ -23,6 +23,7 @@ from supervisor import deploy_supervisor | @@ -23,6 +23,7 @@ from supervisor import deploy_supervisor | ||
| 23 | 23 | ||
| 24 | # MVP engineering estimate per 05 §5.9 -- needs real-world calibration, not an authoritative constant. | 24 | # MVP engineering estimate per 05 §5.9 -- needs real-world calibration, not an authoritative constant. |
| 25 | HEALTH_CHECK_STARTUP_TIMEOUT = 30 | 25 | HEALTH_CHECK_STARTUP_TIMEOUT = 30 |
| 26 | +# MVP engineering estimate per 05 §5.9 -- needs real-world calibration, not an authoritative constant. | ||
| 26 | HEALTH_CHECK_HTTP_TIMEOUT = 10 | 27 | HEALTH_CHECK_HTTP_TIMEOUT = 10 |
| 27 | HEALTH_CHECK_CANARY_TIMEOUT = 120 | 28 | HEALTH_CHECK_CANARY_TIMEOUT = 120 |
| 28 | 29 |