宜博 / lemongraph

Commit 1f58c5bc04a76f2c5d464efdd5c38139c6bdf436

Authored by graphlemon
1 parent 4b293a8e

graphlemon: auto-commit uncommitted worktree changes for e37929c2-d191-4e22-b669-3d4f7f87f150

Inline Side-by-side
Showing 2 changed files with 33 additions and 0 deletions
.claude/agent-memory/planner/MEMORY.md
  View file @1f58c5b
1 - [loop_round bug already fixed](project_loop_round_bug_already_fixed.md) — off-by-one fix AND the REQ-05/REQ-09 comment above _LOOP_LIMIT are both already present in src/org_loop_route.py; re-verify before replanning either as open 1 - [loop_round bug already fixed](project_loop_round_bug_already_fixed.md) — off-by-one fix AND the REQ-05/REQ-09 comment above _LOOP_LIMIT are both already present in src/org_loop_route.py; re-verify before replanning either as open
2 - [scheduler.py busy-timeout comment missing](project_scheduler_busy_timeout_comment_missing.md) — as of 2026-08-03 _BUSY_TIMEOUT_MS (scheduler.py:78) has no inline comment; PL does not self-edit, packages as a Unit for Code Agent 2 - [scheduler.py busy-timeout comment missing](project_scheduler_busy_timeout_comment_missing.md) — as of 2026-08-03 _BUSY_TIMEOUT_MS (scheduler.py:78) has no inline comment; PL does not self-edit, packages as a Unit for Code Agent
  3 +- [deploy_health_check.py startup-timeout comment missing](project_deploy_health_check_startup_timeout_comment_missing.md) — as of 2026-08-03 HEALTH_CHECK_STARTUP_TIMEOUT (line 24) has no inline comment (2nd instance of this pattern); PL does not self-edit
.claude/agent-memory/planner/project_deploy_health_check_startup_timeout_comment_missing.md 0 → 100644
  View file @1f58c5b
  1 +---
  2 +name: project-deploy-health-check-startup-timeout-comment-missing
  3 +description: supervisor/deploy_health_check.py's HEALTH_CHECK_STARTUP_TIMEOUT constant has no comment directly above it as of 2026-08-03; the rationale only lives in the module docstring, far above the constant.
  4 +metadata:
  5 + type: project
  6 +---
  7 +
  8 +As of 2026-08-03, `supervisor/deploy_health_check.py` line 24
  9 +(`HEALTH_CHECK_STARTUP_TIMEOUT = 30`) has no comment directly above it — line 23 is blank, line
  10 +22 is an import. The rationale for the 30s value ("MVP-fixed draft value from 05 §5.9, an
  11 +engineering draft needing real-world calibration") exists only inside the module docstring
  12 +(lines 1-11), not adjacent to the constant itself. Same gap-shape as
  13 +[[project_scheduler_busy_timeout_comment_missing]] (`src/scheduler.py`'s `_BUSY_TIMEOUT_MS`),
  14 +now the second confirmed instance of this pattern in the repo.
  15 +
  16 +**Why:** A user/orchestrator request asked to verify this and, if missing, add exactly one
  17 +inline comment line above the constant. This is a source-code edit, which falls outside the
  18 +Planning Agent role (SOUL.md: "不写业务代码，不替 Code Agent 实现"). Response was to write a
  19 +BRD documenting the gap as a one-line Development Unit for a Code Agent to implement, rather
  20 +than editing `supervisor/deploy_health_check.py` directly — even though the change is trivial.
  21 +Also noted in the BRD: this file lives under PH5 (Deploy Supervisor) scope, which
  22 +`CLAUDE.md` says not to actively build ahead of PH0-PH4 closing — but a one-line comment on
  23 +already-staged code is documentation-only, not new PH5 functionality, so it doesn't violate
  24 +that sequencing constraint.
  25 +
  26 +**How to apply:** If asked again to "check for X comment/fix and edit if missing" as part of a
  27 +"write a BRD" request — for this file, `src/scheduler.py`, or any other constant — do the
  28 +read-only investigation, report the fact, and package any actual code change as a
  29 +requirement/acceptance criterion for Code Agent — do not perform the Edit myself. If a third
  30 +instance of this exact pattern (missing inline rationale comment on an MVP-estimate constant)
  31 +turns up, consider whether it's worth proposing a repo-wide lint/convention Unit instead of
  32 +one-off BRDs each time.