code_diff.patch
3.37 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
diff --git a/.claude/agent-memory/coder/MEMORY.md b/.claude/agent-memory/coder/MEMORY.md
index 0cccb44..cacf348 100644
--- a/.claude/agent-memory/coder/MEMORY.md
+++ b/.claude/agent-memory/coder/MEMORY.md
@@ -1,2 +1,3 @@
- [Loop-limit comment task keeps re-dispatching with zero diff](task_dispatch_loop_limit_comment_repeat.md) — src/org_loop_route.py:38 comment already exists; verify and report, don't re-add
- [deploy_health_check timeout comment fixed 2026-08-03](project_deploy_health_check_startup_timeout_comment_resolved.md) — PH5 already shipped, old "defer" reasoning is stale; check dev-plan closure before citing phase gates
+- [deploy_health_check HTTP timeout comment fixed 2026-08-03](project_deploy_health_check_http_timeout_comment_resolved.md) — separate constant from STARTUP_TIMEOUT case, third planner cycle before a Coder applied it
diff --git a/.claude/agent-memory/coder/project_deploy_health_check_http_timeout_comment_resolved.md b/.claude/agent-memory/coder/project_deploy_health_check_http_timeout_comment_resolved.md
new file mode 100644
index 0000000..780c76e
--- /dev/null
+++ b/.claude/agent-memory/coder/project_deploy_health_check_http_timeout_comment_resolved.md
@@ -0,0 +1,28 @@
+---
+name: project-deploy-health-check-http-timeout-comment-resolved
+description: HEALTH_CHECK_HTTP_TIMEOUT comment gap fixed 2026-08-03 — distinct from the already-resolved STARTUP_TIMEOUT case
+metadata:
+ type: project
+---
+
+`supervisor/deploy_health_check.py`'s `HEALTH_CHECK_HTTP_TIMEOUT = 10` had no comment directly
+above it (only `HEALTH_CHECK_STARTUP_TIMEOUT`, one constant above it, had one — Python comments
+attach only to the immediately following line, so the two constants needed separate comments).
+Three consecutive Planner-role runs (PRD, PRD, then a full SDD defining `DOC-FIX-U038-01`) had
+independently reached this same conclusion without a Coder-role node ever applying the diff.
+
+**Fixed 2026-08-03**: added `# MVP engineering estimate per 05 §5.9 -- needs real-world
+calibration, not an authoritative constant.` directly above `HEALTH_CHECK_HTTP_TIMEOUT = 10`.
+No other lines changed. Verified via `git diff` and by re-running
+`python3 -m unittest supervisor.test_deploy_health_check -v` (13 tests, all pass — comment-only
+change needs no new test).
+
+`HEALTH_CHECK_CANARY_TIMEOUT` still lacks its own comment and remains out of scope (a separate
+potential future task, not part of this fix). See [[project_deploy_health_check_startup_timeout_comment_resolved]]
+for the earlier STARTUP_TIMEOUT fix this complements.
+
+**Why:** this is the third time planning re-derived the same fix without execution — the gap was
+in handoff to a Coder-role node, not in the plan quality.
+
+**How to apply:** N/A, already resolved. If asked to check again, verify on disk first — don't
+assume stale from memory alone.
diff --git a/supervisor/deploy_health_check.py b/supervisor/deploy_health_check.py
index bd1bc11..132d45c 100644
--- a/supervisor/deploy_health_check.py
+++ b/supervisor/deploy_health_check.py
@@ -23,6 +23,7 @@ from supervisor import deploy_supervisor
# MVP engineering estimate per 05 §5.9 -- needs real-world calibration, not an authoritative constant.
HEALTH_CHECK_STARTUP_TIMEOUT = 30
+# MVP engineering estimate per 05 §5.9 -- needs real-world calibration, not an authoritative constant.
HEALTH_CHECK_HTTP_TIMEOUT = 10
HEALTH_CHECK_CANARY_TIMEOUT = 120