test_bug_record.py
5.21 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
"""U-015 tests: c_bug_record_create + the human_reported claim/complete
mechanics. All real (no mocking needed -- sqlite is fast/free/local).
Run: python3 -m unittest src.test_bug_record -v
"""
import json
import unittest
from src import bug_record, schema
class BugRecordTestBase(unittest.TestCase):
def setUp(self):
self.conn = schema.connect(":memory:")
schema.create_schema(self.conn)
self.conn.execute(
"INSERT INTO project (project_id, name, target_folder_path, has_git_repo, status) "
"VALUES ('proj-1', 'P', '/tmp/proj-1', 1, 'active')"
)
self.conn.execute(
"INSERT INTO task (task_id, project_id, goal_text, task_type, status, assigned_org_node) "
"VALUES ('task-1', 'proj-1', 'goal', 'goal', 'validating', 'validator')"
)
self.conn.commit()
def tearDown(self):
self.conn.close()
class CreateBugRecordTest(BugRecordTestBase):
def test_happy_path_creates_routed_validator_record(self):
result = bug_record.create_bug_record(
self.conn, task_id="task-1", description="wall collision misjudged",
root_cause_category="coder", root_cause_detail="SDD §3.2 collision check off-by-one",
suggested_route="fast_lane",
)
row = self.conn.execute(
"SELECT source, status, root_cause_category, root_cause_detail, suggested_route "
"FROM bug_record WHERE bug_id = ?",
(result["bug_id"],),
).fetchone()
self.assertEqual(row, ("validator", "routed", "coder", "SDD §3.2 collision check off-by-one", "fast_lane"))
def test_related_artifact_ids_stored_as_json(self):
result = bug_record.create_bug_record(
self.conn, task_id="task-1", description="x", root_cause_category="planning",
root_cause_detail="d", suggested_route="full_replan",
related_artifact_ids=["art-1", "art-2"],
)
row = self.conn.execute(
"SELECT related_artifact_ids FROM bug_record WHERE bug_id = ?", (result["bug_id"],)
).fetchone()
self.assertEqual(json.loads(row[0]), ["art-1", "art-2"])
def test_invalid_root_cause_category_rejected(self):
with self.assertRaises(bug_record.InvalidRootCauseCategoryError):
bug_record.create_bug_record(
self.conn, task_id="task-1", description="x", root_cause_category="not_a_real_category",
root_cause_detail="d", suggested_route="fast_lane",
)
def test_core_engine_rejected_pre_ph5(self):
# core_engine is PH5-scoped (U-034) -- not accepted yet, matching the
# schema CHECK constraint's own exclusion (see src/schema.py)
with self.assertRaises(bug_record.InvalidRootCauseCategoryError):
bug_record.create_bug_record(
self.conn, task_id="task-1", description="x", root_cause_category="core_engine",
root_cause_detail="d", suggested_route="fast_lane",
)
class HumanReportedFlowTest(BugRecordTestBase):
def _insert_human_bug(self, bug_id="bug-1", status="open"):
self.conn.execute(
"INSERT INTO bug_record (bug_id, task_id, source, description, status) "
"VALUES (?, 'task-1', 'human', 'something looks broken', ?)",
(bug_id, status),
)
self.conn.commit()
def test_claim_transitions_open_to_triaging(self):
self._insert_human_bug()
bug_record.claim_human_reported_bug(self.conn, "bug-1")
status = self.conn.execute("SELECT status FROM bug_record WHERE bug_id = 'bug-1'").fetchone()[0]
self.assertEqual(status, "triaging")
def test_claim_rejects_already_claimed_bug(self):
self._insert_human_bug(status="triaging")
with self.assertRaises(ValueError):
bug_record.claim_human_reported_bug(self.conn, "bug-1")
def test_claim_rejects_unknown_bug_id(self):
with self.assertRaises(ValueError):
bug_record.claim_human_reported_bug(self.conn, "no-such-bug")
def test_complete_triage_updates_in_place_not_new_record(self):
self._insert_human_bug()
bug_record.claim_human_reported_bug(self.conn, "bug-1")
bug_record.complete_human_reported_triage(
self.conn, "bug-1", root_cause_category="coder",
root_cause_detail="found it", suggested_route="fast_lane",
)
count = self.conn.execute("SELECT COUNT(*) FROM bug_record").fetchone()[0]
self.assertEqual(count, 1)
row = self.conn.execute(
"SELECT status, root_cause_category, root_cause_detail, suggested_route "
"FROM bug_record WHERE bug_id = 'bug-1'"
).fetchone()
self.assertEqual(row, ("routed", "coder", "found it", "fast_lane"))
def test_complete_triage_rejects_invalid_category(self):
self._insert_human_bug()
bug_record.claim_human_reported_bug(self.conn, "bug-1")
with self.assertRaises(bug_record.InvalidRootCauseCategoryError):
bug_record.complete_human_reported_triage(
self.conn, "bug-1", root_cause_category="nonsense",
root_cause_detail="x", suggested_route="fast_lane",
)
if __name__ == "__main__":
unittest.main()