diff --git a/.claude/agent-memory/planner/MEMORY.md b/.claude/agent-memory/planner/MEMORY.md index 6061057..1be0685 100644 --- a/.claude/agent-memory/planner/MEMORY.md +++ b/.claude/agent-memory/planner/MEMORY.md @@ -1,3 +1,3 @@ - [loop_round bug already fixed](project_loop_round_bug_already_fixed.md) — off-by-one fix AND the REQ-05/REQ-09 comment above _LOOP_LIMIT are both already present in src/org_loop_route.py; re-verify before replanning either as open - [scheduler.py busy-timeout comment missing](project_scheduler_busy_timeout_comment_missing.md) — as of 2026-08-03 _BUSY_TIMEOUT_MS (scheduler.py:78) has no inline comment; PL does not self-edit, packages as a Unit for Code Agent -- [deploy_health_check.py startup-timeout comment missing](project_deploy_health_check_startup_timeout_comment_missing.md) — as of 2026-08-03 HEALTH_CHECK_STARTUP_TIMEOUT (line 24) has no inline comment (only module docstring); PH5-scoped, package as Unit, don't self-edit +- [deploy_health_check.py startup-timeout comment](project_deploy_health_check_startup_timeout_comment_missing.md) — RESOLVED 2026-08-03: line 24 now has the inline comment; re-read file before re-flagging diff --git a/.claude/agent-memory/planner/project_deploy_health_check_startup_timeout_comment_missing.md b/.claude/agent-memory/planner/project_deploy_health_check_startup_timeout_comment_missing.md index 9dd7ea1..6854dea 100644 --- a/.claude/agent-memory/planner/project_deploy_health_check_startup_timeout_comment_missing.md +++ b/.claude/agent-memory/planner/project_deploy_health_check_startup_timeout_comment_missing.md @@ -1,26 +1,25 @@ --- name: project-deploy-health-check-startup-timeout-comment-missing -description: supervisor/deploy_health_check.py's HEALTH_CHECK_STARTUP_TIMEOUT constant has no comment directly above it as of 2026-08-03; rationale only lives in the module docstring, far above the constant. +description: RESOLVED 2026-08-03 — supervisor/deploy_health_check.py:24 now has an inline comment directly above HEALTH_CHECK_STARTUP_TIMEOUT; do not re-flag as missing without re-reading the file. metadata: type: project --- -As of 2026-08-03, `supervisor/deploy_health_check.py` line 24 -(`HEALTH_CHECK_STARTUP_TIMEOUT = 30`) has no comment directly above it — the lines immediately -preceding it are a blank line and `from supervisor import deploy_supervisor` (line 22). The -rationale ("MVP-fixed draft value from 05 §5.9, needs real-world calibration") exists only in -the module docstring at the top of the file (lines 1-11), which also covers the sibling -constants `HEALTH_CHECK_HTTP_TIMEOUT` and `HEALTH_CHECK_CANARY_TIMEOUT`. +RESOLVED as of 2026-08-03. `supervisor/deploy_health_check.py` line 24 now reads: +`# MVP engineering estimate per 05 §5.9 -- needs real-world calibration, not an authoritative +constant.` directly above `HEALTH_CHECK_STARTUP_TIMEOUT = 30` (line 25). Originally flagged +missing earlier the same day (only the module docstring covered the rationale); a Code Agent +edit landed the one-line comment since then (see also the sibling entry +[[project_scheduler_busy_timeout_comment_missing]], same pattern, not yet confirmed resolved). -**Why:** Same verify-then-conditionally-edit request pattern as -[[project_scheduler_busy_timeout_comment_missing]] — check for an inline comment adjacent to a -specific constant, add exactly one line if missing. As PL I do not edit source code -(SOUL.md: "不写业务代码,不替 Code Agent 实现"), so the gap gets packaged as a one-line -Development Unit for Code Agent rather than fixed directly. +**Why:** Same verify-then-conditionally-edit request pattern was re-run twice in one day +(2026-08-03) and the second run found the gap already closed. As PL I do not edit source code +(SOUL.md: "不写业务代码,不替 Code Agent 实现") — this memory exists so a third re-run doesn't +redundantly re-flag or re-package a Unit for work that's already landed. **How to apply:** If asked again about this constant or its siblings -(`HEALTH_CHECK_HTTP_TIMEOUT`, `HEALTH_CHECK_CANARY_TIMEOUT`) in `deploy_health_check.py`, re-read -the file first — don't assume the module docstring counts as "directly above" the constant, and -don't assume a fix from a prior conversation already landed. This module is PH5-scoped -(Deploy Supervisor) and out of active development per CLAUDE.md's "PH5 is not in scope yet", so -any resulting Development Unit should be queued, not treated as urgent/blocking. +(`HEALTH_CHECK_HTTP_TIMEOUT`, `HEALTH_CHECK_CANARY_TIMEOUT`) in `deploy_health_check.py`, +re-read the file first — the comment landed for `HEALTH_CHECK_STARTUP_TIMEOUT` specifically; +the siblings were never confirmed to have their own comments and should still be checked fresh +rather than assumed resolved by association. Module is PH5-scoped (Deploy Supervisor) per +CLAUDE.md's "PH5 is not in scope yet".